Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs/tasks): fix task pingcap-get-set-release-version for hotfix cases #1271

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Sep 27, 2024

Avoid route in RC build logic, like this:

image
This pull request includes a small change to the apps/prod/tekton/configs/tasks/pingcap-get-set-release-version.yaml file. The change updates the regular expression used to filter git tags to include additional patterns.

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from purelind September 27, 2024 09:05
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Sep 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, the key changes are:

  • In the pingcap-get-set-release-version.yaml file, the grep command in line 25 has been updated to remove non-standard tags with the format 202[1-9][0-1][0-9][0-3][0-9]-[0-9a-f]{7,10}.

The potential problem with this change is that it could break the existing functionality of deleting non-standard tags. The new regular expression may not capture all the non-standard tags, leading to errors or unexpected behavior.

To fix this, the regular expression should be tested thoroughly to ensure that it covers all possible non-standard tags. Additionally, the changes should be deployed to a staging environment first to ensure that the functionality is not broken before deploying to production.

Overall, this seems like a relatively minor change that should not have a significant impact on the CI/CD pipeline.

@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 27, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 168911d into main Sep 27, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/hotfix-version-get branch September 27, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant